-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Schematic release 23.9.1 #1283
Schematic release 23.9.1 #1283
Conversation
…nt manifest is correct
…r-pull-annotations
[bug fix] Renamed function related to setting background color of required columns
…r-pull-annotations
…tions-param [bug fix] Do not pull annotations when use_annotations set to False and there is no existing manifests
…to-component Add unit test for `add_root_to_component` function
…n-test [bug fix] Skipped submission when running API tests remotely
…annotations Refactored logic when pulling annotations
@GiaJordan @mialy-defelice @andrewelamb Sorry! I should have reviewed this release PR sooner. When I ran
For generating manifests an an excel spreadsheet, please see more details and the fix in this PR: #1284. Apparently when doing testing for the PRs related to fixing the use_annotations parameter issues, I didn't test thoroughly enough. Luckily the tests caught the error. I don't think we should release until #1284 gets merged. I will update the description of this release PR to "depends on" #1284 For the manifest download endpoint, I think the tests are outdated. The issue is we switched to download manifest to a temporary folder but the tests are still checking if we are downloading manifests to the old location. I am a bit surprised that we didn't catch this issue earlier since we have been using Github workflows to run |
[bug fix] Fix issues when generating an existing manifest as an excel sheet
🎉 All dependencies have been resolved ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving based on @andrewelamb's documentation of test results and per his conversation with @milen-sage about moving ahead with the release due to the low severity of the found bugs
Bugs fix:
Other:
add_root_to_component
function #1282Depends on #1284