Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schematic release 23.9.1 #1283

Merged
merged 54 commits into from
Sep 5, 2023
Merged

Schematic release 23.9.1 #1283

merged 54 commits into from
Sep 5, 2023

Conversation

@linglp linglp changed the title 23.8.2 Schematic release 23.8.2 Aug 24, 2023
…tions-param

[bug fix] Do not pull annotations when use_annotations set to False and there is no existing manifests
@linglp linglp temporarily deployed to github-pages August 25, 2023 16:21 — with GitHub Actions Inactive
…to-component

Add unit test for `add_root_to_component` function
@linglp linglp temporarily deployed to github-pages August 27, 2023 03:32 — with GitHub Actions Inactive
…n-test

[bug fix] Skipped submission when running API tests remotely
@linglp linglp temporarily deployed to github-pages August 28, 2023 18:18 — with GitHub Actions Inactive
…annotations

Refactored logic when pulling annotations
@linglp linglp temporarily deployed to github-pages August 29, 2023 16:02 — with GitHub Actions Inactive
@linglp
Copy link
Contributor

linglp commented Aug 29, 2023

@GiaJordan @mialy-defelice @andrewelamb

Sorry! I should have reviewed this release PR sooner. When I ran test_api.py locally, I noticed that there are two categories of tests that are failing:

  • Tests that are related to generating manifests as an excel spreadsheet
  • Tests that are related to downloading manifests

For generating manifests an an excel spreadsheet, please see more details and the fix in this PR: #1284. Apparently when doing testing for the PRs related to fixing the use_annotations parameter issues, I didn't test thoroughly enough. Luckily the tests caught the error. I don't think we should release until #1284 gets merged. I will update the description of this release PR to "depends on" #1284

For the manifest download endpoint, I think the tests are outdated. The issue is we switched to download manifest to a temporary folder but the tests are still checking if we are downloading manifests to the old location. I am a bit surprised that we didn't catch this issue earlier since we have been using Github workflows to run test_api.py the tests seemed to be passing there. Anyway please refer to this Jira issue FDS 793 to update the test related to manifest/download. (Note: I don't want to link the Jira issue here to avoid associating this PR with the Jira key for FDS 793)

[bug fix] Fix issues when generating an existing manifest as an excel sheet
@dpulls
Copy link

dpulls bot commented Aug 29, 2023

🎉 All dependencies have been resolved !

@linglp linglp temporarily deployed to github-pages August 29, 2023 21:34 — with GitHub Actions Inactive
Copy link
Contributor

@GiaJordan GiaJordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on @andrewelamb's documentation of test results and per his conversation with @milen-sage about moving ahead with the release due to the low severity of the found bugs

@andrewelamb andrewelamb changed the title Schematic release 23.8.2 Schematic release 23.9.1 Sep 5, 2023
@andrewelamb andrewelamb merged commit 12d7707 into main Sep 5, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants