-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BugFix: Fix error when use_annotations=True
for record based metadata where there are no existing annotations
#1285
Conversation
@GiaJordan I'm not seeing any tests for the new functionality. |
@andrewelamb No, this PR is restoring logic was already present in the codebase and is not novel. Adding an additional test did not seem necessary |
@GiaJordan If case this was already covered by existing tests, wouldn't those have been failing up till now? |
@andrewelamb it seems covering this case increases runtime, so that's why nothing was failing. |
@GiaJordan gotcha |
@andrewelamb , @mialy-defelice After our discussion I added a test for this case. Parameterizing the other fixtures would've likely caused issues for the existing tests that used them, so to simplify things the one for this case is separate. It will run twice, once for a dataset where there is a manifest to pull from and once where the dataset is empty. I've also gone through the CLI and API tests that @mialy-defelice performs when changing this part of the manifest generator. All were fine except for using the Please let me know if either of you have questions! |
use_annotations=True
for record based metadata where there are no existing annotations
This PR provides logic to cover the case where
use_annoations
is set toTrue
, but the metadata is not file based. In this case, an empty manifest is generated to create the manifest, and a warning message is logged to alert the user that annotations could not be pulled.