-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automation of github release and tag, and publish to pypi #1414
Conversation
@linglp @mialy-defelice Coudl you look at the changes I just made? To solve the problems we dicussed on Wednesday, there are now two workflows. |
.github/workflows/publish_tag.yml
Outdated
@@ -2,7 +2,7 @@ name: Publish to PyPI | |||
on: | |||
push: | |||
tags: | |||
- 'v[1-9][0-9].[0-9]+.[0-9]+' | |||
- 'v[1-9][0-9].[0-9]+.[0-9].[a-z]+' | |||
branches: [main] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even if we want to keep two workflows, can we clean up this workflow more? Here, this workflow will still get triggered because branches: [main]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh maybe I misunderstand how this works, but I thought this would require both the branch to be main and the tag to match. Otherwise this would have been triggered before every time we pushed to main right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went ahead and removed that line
@andrewelamb could you also make sure tags like |
Quality Gate passedIssues Measures |
@linglp the regex for the tag is now:
See the description above. I tested this out here: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the old workflow is still referencing override_version.py right? So if you delete override_version.py, the old workflow will fail?
@linglp Good point I'll make that fix |
@andrewelamb additionally, I tried testing if dev tags will get tirggered by your regex, but it didn't seem to work. Github regex is different from regular regex... I found out when I was working on the docker publish workflow that even though an external tool might say that xx would work given a regex rule, it might still not work for github. To reproduce :
When I checked the github action tab, the workflow didn't get triggered. And then you could remove the tag both locally and remotely |
@andrewelamb if you are not going to continue working on this, can this PR be closed? |
@linglp Yep! |
I'm going to leave the branch for now in case anyoen wants to take a crack at it in the near future. |
The tag regex has been improved to:
^v[1-9][0-9]\.[0-9]+\.[0-9]\.[a-z]+$
\.[a-z]+
added means thatv24.4.1
orv24.4.1-dev
won't trigger the workflowv24.4.1.dev
will trigger the workflow