Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fds 1843 use graph #1425
Fds 1843 use graph #1425
Changes from 47 commits
1c67b4a
a986b39
0390b69
37bbf74
4596560
b5dd8e4
c8da900
601b5d0
c6d01de
77979c7
9907b4e
481ebd3
f63231a
f3fdc41
032771f
bf0e9ba
bc59218
5973a75
bf1a449
69bb182
d93aa9d
aef4f62
08b2ae5
a088d63
68672c3
de07c55
77f5ec4
5934ed5
51313bd
e4e1368
9a78a18
05b4fe0
0964501
697cc3e
774dc91
bb7c450
8f5bc1a
35c13dd
f8c14d4
13c9ffc
9205d6d
172e1b1
d4d3a30
730b227
795e263
0ddb552
537af6f
23b7e1d
fa5e308
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might want this to be
if graph_data_model is None
I'm not sure hownx.MultiDiGraph
handles thruthyness.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Take a look at this doc here: https://www.draconianoverlord.com/2017/11/28/using-given/when/then-for-tests.html/
Personally, I am a huge fan of giving each test a very explicit purpose. The way I do this is clearly state a set of criteria the test is expected to following in a:
I added some tests like this in: #1472 if you wanted some examples