Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schematic 24.7.1 Release #1454

Merged
merged 144 commits into from
Jul 2, 2024
Merged

Schematic 24.7.1 Release #1454

merged 144 commits into from
Jul 2, 2024

Conversation

andrewelamb
Copy link
Contributor

@andrewelamb andrewelamb commented Jul 2, 2024

  • Bug Fix to prevent double manifest version increases in synapse FDS-1875
  • Remove service_accout_creds_synapse_id from schematic config FDS-1956
  • Bug Fix Publication manifest DOI validation rule FDS-1894 (HTAN) - Changed to investigation ticket, so no fix will be included in the release
  • Record based manifests should not include file entity’s if included in the folder FDS-2105: Added based on blocker from VEOIBD on June 6th

linglp and others added 20 commits June 19, 2024 11:11
…rsion

technical debt: added unit test for changeFileMetaData function
feat: added tracing to schematic code base for manifest generate and manifest submission
…tation

feat: set annotations in an async way when submitting a manifest
…anifest-FDS-2015

BugFix: Files no longer added to records based manifests
technical debt: added isort to pre-commit hook in schematic repo
…ync-set-annotation

Revert "feat: set annotations in an async way when submitting a manifest"
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

schematic_api/Dockerfile Dismissed Show dismissed Hide dismissed
Copy link

sonarcloud bot commented Jul 2, 2024

@andrewelamb
Copy link
Contributor Author

@linglp Is the security issue raised by sonarcloud somethign we need ot worry about?

@linglp
Copy link
Contributor

linglp commented Jul 2, 2024

@linglp Is the security issue raised by sonarcloud somethign we need ot worry about?

I dismissed it for now.. that issue was fixed in mono repo.

Copy link
Contributor

@linglp linglp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve it for now after trusting that appropriate tests have been done.

@linglp linglp changed the title 24.7.1 Schematic 24.7.1 Release Jul 2, 2024
@andrewelamb andrewelamb merged commit 0d2527a into main Jul 2, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants