Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable google credentials tests #1459

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Enable google credentials tests #1459

merged 1 commit into from
Jul 19, 2024

Conversation

GiaJordan
Copy link
Contributor

@GiaJordan GiaJordan commented Jul 16, 2024 •
edited
Loading

Enable tests that require google credentials

@GiaJordan GiaJordan marked this pull request as draft July 16, 2024 17:23
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@GiaJordan GiaJordan changed the title run google creds tests Enable google credentials tests Jul 17, 2024
@GiaJordan GiaJordan marked this pull request as ready for review July 17, 2024 20:08
@andrewelamb
Copy link
Contributor

@GiaJordan So they just worked without having to change anything? (besdies turning them on in the github workflow)?

@GiaJordan GiaJordan merged commit 7563640 into develop Jul 19, 2024
4 checks passed
@GiaJordan GiaJordan deleted the develop-google-creds-tests-FDS-1612 branch July 19, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewelamb andrewelamb andrewelamb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GiaJordan @andrewelamb