Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codeowners so PR's are automatically tagged with reviewers #1470

Closed

Conversation

thomasyu888
Copy link
Member

Problem
Code reviewers have to be assigned manually per PR.

Solution
Add codeowners so PR's are automatically tagged with reviewers

Copy link

sonarcloud bot commented Aug 23, 2024

@@ -0,0 +1,2 @@
* @Sage-Bionetworks/fair-data
* @Sage-Bionetworks/python-client-developers
Copy link
Member Author

@thomasyu888 thomasyu888 Aug 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you could provide this team write access to this repo, that would be fantastic!

OR... if there is a schematic-developer team, lets add ourselves to that

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's no schematic-developer team. I added @Sage-Bionetworks/python-client-developers manually here:
Screenshot 2024-08-25 at 5 04 18 PM

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just changed the role to "maintain"

@linglp
Copy link
Contributor

linglp commented Aug 25, 2024

@thomasyu888 ugh I finally understand why the tests are failing! I think it is because you forked the repository. Next time, please feel free to create a branch. If you fork the repository, you will have to add SYNAPSE_ACCESS_TOKEN and SERVICE_ACCOUNT_CREDS environment variables yourself. SYNAPSE_ACCESS_TOKEN is your synapse access token, but SERVICE_ACCOUNT_CREDS is a bit hard to obtain. We used to have a synapse template that let people download the same service account credentials but that approach was not secure and we deprecated that. The new way of getting SERVICE_ACCOUNT_CREDS can be found here: https://scribehow.com/shared/Enable_Google_Drive_and_Google_Sheets_APIs_for_project__yqfcJz_rQVeyTcg0KQCINA
But the easiest way is of course just to create a new branch using our repo.

@thomasyu888
Copy link
Member Author

@thomasyu888 ugh I finally understand why the tests are failing! I think it is because you forked the repository. Next time, please feel free to create a branch. If you fork the repository, you will have to add SYNAPSE_ACCESS_TOKEN and SERVICE_ACCOUNT_CREDS environment variables yourself. SYNAPSE_ACCESS_TOKEN is your synapse access token, but SERVICE_ACCOUNT_CREDS is a bit hard to obtain. We used to have a synapse template that let people download the same service account credentials but that approach was not secure and we deprecated that. The new way of getting SERVICE_ACCOUNT_CREDS can be found here: https://scribehow.com/shared/Enable_Google_Drive_and_Google_Sheets_APIs_for_project__yqfcJz_rQVeyTcg0KQCINA
But the easiest way is of course just to create a new branch using our repo.

Thanks @linglp ! See this: https://sagebionetworks.slack.com/archives/C07HLTBS5D2/p1724456854221899?thread_ts=1724454270.877609&cid=C07HLTBS5D2

@linglp linglp self-requested a review August 25, 2024 23:00
Copy link
Contributor

@linglp linglp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasyu888
Copy link
Member Author

Closing due to FAIR having their own process for code reviews.

@thomasyu888 thomasyu888 deleted the add-codeowners branch August 26, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants