-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FDS-2294] Prevent including project name twice in walked path #1474
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 LGTM - but will leave it to FAIR for final review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thomasyu888 @BryanFauble Thank you for the PR. It looks good to me overall! I appreciate the efforts of setting up global variables and remove the unnecessary fixtures too! I just left a small comment to modify a unit test so that the newly introduce logic can get covered. I also tested it /manifest/generate
endpoint using my own test projects. That looks good too. Thanks again.
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @BryanFauble! LGTM
Problem:
schematic - main/schematic - main/DataTypeX/Sample_A.txt
Solution:
Testing: