Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FDS-2294] Prevent including project name twice in walked path #1474

Merged
merged 4 commits into from
Aug 27, 2024

Conversation

BryanFauble
Copy link
Collaborator

Problem:

  1. When the project structure was being walked the name of the project was being included twice: schematic - main/schematic - main/DataTypeX/Sample_A.txt
  2. Lots of small issues flagged by sonar

Solution:

  1. Add in a small check to determine if the project name is already being included in the directory structure, and not include the duplicated data if it's the case. I was not certain if I could totally remove adding the project name manually, so that is why I made the check in this way.

Testing:

  1. I verified I could run the tests in question around this logic (Note: This does not contain all of the tests noted in the jira, just a few):
    image

Copy link
Member

@thomasyu888 thomasyu888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 LGTM - but will leave it to FAIR for final review

Copy link
Contributor

@linglp linglp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thomasyu888 @BryanFauble Thank you for the PR. It looks good to me overall! I appreciate the efforts of setting up global variables and remove the unnecessary fixtures too! I just left a small comment to modify a unit test so that the newly introduce logic can get covered. I also tested it /manifest/generate endpoint using my own test projects. That looks good too. Thanks again.

Copy link

sonarcloud bot commented Aug 27, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Copy link
Contributor

@linglp linglp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @BryanFauble! LGTM

@BryanFauble BryanFauble merged commit 34d1760 into develop Aug 27, 2024
4 of 6 checks passed
@BryanFauble BryanFauble deleted the fds-2294-test-api-changes branch August 27, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants