Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SAH-114]: Add new login screen across all the apps #218

Merged
merged 20 commits into from
Sep 25, 2024
Merged

[SAH-114]: Add new login screen across all the apps #218

merged 20 commits into from
Sep 25, 2024

Conversation

mde3
Copy link
Collaborator

@mde3 mde3 commented Sep 16, 2024 •
edited
Loading

Tasks

  • Hide navbar when user isn't signed in
  • Implement new login screen UI across the apps

Screenshot
screencapture-localhost-3000-auth-signin-2024-09-17-00_52_45

@mde3 mde3 self-assigned this Sep 16, 2024
Maiz27
Maiz27 reviewed Sep 17, 2024
View reviewed changes
Copy link
Collaborator

@Maiz27 Maiz27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Work! Left some comments.

packages/features/auth/AuthCard.tsx Outdated Show resolved Hide resolved
apps/agent/src/pages/suppliers/index.tsx Show resolved Hide resolved
@Maiz27 Maiz27 linked an issue Sep 17, 2024 that may be closed by this pull request
[SAH-114]: Add new login screen across all the apps #216
Closed
Maiz27
Maiz27 approved these changes Sep 17, 2024
View reviewed changes
Copy link
Collaborator

@Maiz27 Maiz27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Emmanuel-Melon
Emmanuel-Melon approved these changes Sep 25, 2024
View reviewed changes
Copy link
Collaborator

@Emmanuel-Melon Emmanuel-Melon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@Emmanuel-Melon Emmanuel-Melon merged commit c0cc761 into develop Sep 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Maiz27 Maiz27 Maiz27 approved these changes

@Emmanuel-Melon Emmanuel-Melon Emmanuel-Melon approved these changes

Assignees

@mde3 mde3

Labels
Admin 👨🏾‍💻 Agent 🦺 Client 🤵🏾‍♂️ Courier 🚴🏾‍♀️ enhancement 🌻 New feature or request front-end 🦋 ready_for_review 🍀 work_in_progress 🐣
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SAH-114]: Add new login screen across all the apps
4 participants
@mde3 @Emmanuel-Melon @Maiz27 @eman-bfloat