Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: enhance regex album name post processing #121

Merged

Conversation

DSchmidtDev
Copy link
Contributor

This PR enhances the regex album name post processing to
(1) be able to use equal signs in your regex
(2) use python regex module which allows more features like e.g. infinite width lookbehind patterns

and just for convenience adding a gitignore file

@Salvoxia
Copy link
Owner

Salvoxia commented Feb 2, 2025

Thanks!
A question regarding the new requirement regex==2024.11.6. That looks like an awfully recent version and I'm worried about compatibility with older systems out there. Is that version absolutely required?

@DSchmidtDev
Copy link
Contributor Author

It's not absolutely required. But I personally like to have pinned dependencies to have clarity about the version and behavior (if it might change in future) especially if there are no tests to cover it.
I guess most of the user are using the docker image with python3.12 anyway so there should not be any conflicts.

But its your project and if you want we can remove the version

@Salvoxia Salvoxia merged commit d225b47 into Salvoxia:main Feb 2, 2025
3 checks passed
@Salvoxia
Copy link
Owner

Salvoxia commented Feb 2, 2025

It occurred to me that venvs should be an option, too. So let's roll with it.

@DSchmidtDev DSchmidtDev deleted the fix/enhance_regex_post_processing branch February 3, 2025 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants