Conformer speechbrain1.0 #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TParcollet
previously approved these changes
Sep 2, 2024
There was a problem hiding this comment.
@shucongzhang please run the precommit tests on all the files as some things are failing. The tests are also failing, if you do pytest tests/test_summary_mixing.py they do not pass. Once these two things are fixed, we should be able to emrge.
|
@shucongzhang the changes made to Conformer.py (especially return hidden stages) will need a main SpeechBrain merge for your next PR. This is because I fixed it on the main repo and the PR should soon be merged (you could also pickup the new code from the best rq PR in the main repo). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the yaml and the layernom flag to produce the Conformer results with SpeechBrain 1.0