-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Adding basic native memory extraction. No parsed summary yet. #1
base: main
Are you sure you want to change the base?
Conversation
How it looks on my machine right now:
|
Maybe we can use redhat-developer/vscode-java#3395 (comment) or directly extract the same info from ps/pmap -x, too, to save bothering the JVM with additional work which could affect the measurement |
Should we maybe have different sets of JVM parameters depending on what we're going to be measuring? There's several more configuration flags which I'd like to enable to improve diagnostics (e.g. Not sure how to best do this, thoughts? |
My original idea was to extend it later to have a more detailed summary on what type of memory we are using. But maybe we don't need that kind of detail here? |
We can implement the script to run with different options on what to measure and depending on those parameters, it will impact performance more or less. But if we are comparing under the same conditions, performance impact is not that important? |
flag Also added basic CPU average usage.
New commit. Added basic CPU average usage. Now we have the If we want to use The
|
|
||
|
||
if [ "$MEMORY_LEVEL" = "detail" ]; then | ||
podman exec -it $TEMP_INTANCE_NAME bash -c "jcmd 1 VM.native_memory baseline scale=MB" > /dev/null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not using the jcmd I sent which just focus on RSS?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because the idea is to gather more statistics to offer a better summary later.
IDK if is too advanced, but we could attach perf stat for the relevant period of time, getting few metrics, but probably we need to add This will add few counters, including the AVGCPU but not only... |
I would leave that for another PR. But sounds like a good idea. |
Very basic native memory statistics output. It still needs some parsing of the raw data to get a better statistics overview.