Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update group permissions #622

Merged
merged 18 commits into from
Nov 15, 2024
Merged

feat: update group permissions #622

merged 18 commits into from
Nov 15, 2024

Conversation

Flemmli97
Copy link
Contributor

@Flemmli97 Flemmli97 commented Nov 8, 2024 •
edited
Loading

What this PR does 📖

  • Renamed SetGroupName to EditGroupInfo

  • Added RemoveParticipants permission. If someone has this they can remove a user from a group

  • EditGroupInfo now allows: Renaming group name + description, changing group icon and banner

  • Changed no permission error from PublicKeyInvalid to Unauthorized

  • Updates the tests which only used direct conversation instead of group

dariusc93
dariusc93 reviewed Nov 8, 2024
View reviewed changes
Copy link
Contributor

@dariusc93 dariusc93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments. Not sure I like or completely agree with moving multiple functionalities under a single permission here (eg changing/updating name, images, etc).

extensions/warp-ipfs/src/store/message/task.rs Outdated Show resolved Hide resolved
extensions/warp-ipfs/src/store/message/task.rs Outdated Show resolved Hide resolved
extensions/warp-ipfs/src/store/message/task.rs Outdated Show resolved Hide resolved
extensions/warp-ipfs/src/store/message/task.rs Outdated Show resolved Hide resolved
extensions/warp-ipfs/src/store/message/task.rs Outdated Show resolved Hide resolved
extensions/warp-ipfs/src/store/message/task.rs Outdated Show resolved Hide resolved
warp/src/raygun/mod.rs Outdated Show resolved Hide resolved
@Flemmli97
Copy link
Contributor Author

Left some comments. Not sure I like or completely agree with moving multiple functionalities under a single permission here (eg changing/updating name, images, etc).

was talking to hugo about that. and we decided for name, description, icon and banner we would use one permission

@dariusc93
Copy link
Contributor

was talking to hugo about that. and we decided for name, description, icon and banner we would use one permission

Not sure if it should be that narrow imho

dariusc93
dariusc93 reviewed Nov 14, 2024
View reviewed changes
warp/src/raygun/mod.rs Outdated Show resolved Hide resolved
@dariusc93
Copy link
Contributor

Can you correct the test?

@dariusc93 dariusc93 merged commit ca1d8bb into main Nov 15, 2024
3 checks passed
@dariusc93 dariusc93 deleted the update_permission branch November 15, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashneverdawn ashneverdawn ashneverdawn approved these changes

@dariusc93 dariusc93 dariusc93 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Flemmli97 @dariusc93 @ashneverdawn