Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

screenobject(update): update switch sliders validation methods #641

Merged
merged 8 commits into from
Feb 23, 2024

Conversation

luisecm
Copy link
Collaborator

@luisecm luisecm commented Feb 22, 2024

What this PR does 📖

  • Update Switch Sliders validation method to click on slider and then validate that it changes. I noticed that there is some flakiness on tests happening not often, when appium does the assertion of the change before the slider has changed, and then test fails apparently because the switch was not clicked, but at the end it was just a race condition happening

Which issue(s) this PR fixes 🔨

  • Resolve #

Special notes for reviewers 🗒️

Additional comments 🎤

@github-actions github-actions bot added Missing dev review Failed Automated Test The latest commit on this PR failed automation tests labels Feb 22, 2024
Copy link

github-actions bot commented Feb 22, 2024

UI Automated Test Results Summary for MacOS/Windows

525 tests   473 ✅  3h 2m 15s ⏱️
 44 suites   52 💤
  3 files      0 ❌

Results for commit 7aa6568.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Feb 22, 2024

UI Automated Tests execution is complete! You can find the test results report here

@github-actions github-actions bot removed the Failed Automated Test The latest commit on this PR failed automation tests label Feb 23, 2024
@luisecm luisecm merged commit 3c3c830 into dev Feb 23, 2024
10 checks passed
@luisecm luisecm deleted the luis/update-switches branch February 23, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant