Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

screenobject(update): minor fixes for flaky macos tests #672

Merged
merged 7 commits into from
Apr 2, 2024
Merged

Conversation

luisecm
Copy link
Collaborator

@luisecm luisecm commented Mar 27, 2024

What this PR does 📖

  • Minor fix for screenobject on Accessiblity Settings since appium was opening Settings Open Dyslexic section from MacOS instead of Uplink on macos tests
  • Minor fix for screenobject on Create Pin Screen to retry entering pin on login when pin entered is not matching with value passed to function

Which issue(s) this PR fixes 🔨

  • Resolve #

Special notes for reviewers 🗒️

Additional comments 🎤

@github-actions github-actions bot added Missing dev review Failed Automated Test The latest commit on this PR failed automation tests labels Mar 27, 2024
Copy link

github-actions bot commented Mar 27, 2024

UI Automated Test Results Summary for MacOS/Windows

507 tests   464 ✅  3h 17m 37s ⏱️
 44 suites   43 💤
  3 files      0 ❌

Results for commit 7c4c61c.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Mar 27, 2024

UI Automated Tests execution is complete! You can find the test results report here

@github-actions github-actions bot removed the Failed Automated Test The latest commit on this PR failed automation tests label Mar 29, 2024
@stavares843
Copy link
Member

seems good to go, merging 🎉

@stavares843 stavares843 merged commit ea18f94 into dev Apr 2, 2024
1 of 2 checks passed
@stavares843 stavares843 deleted the luis/macos branch April 2, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants