[Unblinding UTXO] Ability to detect and spend unblinded addresses #36 #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claddyy
commented
Oct 9, 2024
rust/src/api/wallet.rs
Outdated
Comment on lines
467
to
470
| let blinding_key = wallet.blinding_key().unwrap(); | ||
| let unblinded_address = ""; | ||
| let unblinded_address = println!("The unblinded address is {}", unblinded_address); | ||
| println!("Fund the unblinded address"); |
There was a problem hiding this comment.
I'll have to create a function that converts unblinded_address to blinded using the binding key.
I couldn't find any method that does this either in lwk-dart repo or in lwk.
There was a problem hiding this comment.
you mean blinded to unblinded? We don't need to go the other way around.
let unblinded_address = confidential_address.standard;
There was a problem hiding this comment.
This struct has methods to go either direction:
https://docs.rs/elements/0.24.1/elements/address/struct.Address.html
rust/src/api/wallet.rs
Outdated
Comment on lines
458
to
459
| let electrum_url = "les.bullbitcoin.com:995".to_string(); | ||
| wallet.sync(electrum_url.clone()).unwrap(); |
There was a problem hiding this comment.
Since we're on testnet now, I'll change this to use blockstream testnet url.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #36
This PR works on adding the solutions from Blockstream/lwk#38 (comment)