Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FSharp.Control.Websockets to 0.3.0 to fix WebSockets #389

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

64J0
Copy link
Contributor

@64J0 64J0 commented Sep 3, 2024

Description:

With this PR, I'm updating the FSharp.Control.Websockets package version to 0.3.0 so we can use WebSockets again. Btw, this issue is currently blocking me with some code.

Related issues:

How to test:

# first, assert that the problem is real
git checkout main # make sure that this branch is updated
dotnet tool restore # we need paket
cd sample/ChannelsSample
dotnet run

# use some tool to test the websocket connection
# I'm using wscat, since it's easy to use
# https://github.com/websockets/wscat
wscat -c ws://localhost:8085/channel
# notice the error right next
Connected (press CTRL+C to quit)
Disconnected (code: 1006, reason: "")

# now test this branch code
git checkout fix-ws # assert that the code is updated
dotnet run
wscat -c ws://localhost:8085/channel

# assert that it's working fine, and the connection was correctly stablished

# =======================
# another option is to open the sample web page, going to localhost:8085
# and testing it there (paying attention to the server logs)
# you can use the following endpoints through the terminal:
curl localhost:8085/ping
curl localhost:8085/ping?message=hi

paket.dependencies Outdated Show resolved Hide resolved
@64J0 64J0 requested a review from baronfel September 3, 2024 23:38
@64J0
Copy link
Contributor Author

64J0 commented Sep 4, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sample/ChannelsSample throws error on join
2 participants