Day 5 #3
Open
Day 5 #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Better error handler - Specific trait for the ranking algorithm - Separate GitHub APi handlers from the service implementation - Updated documentation for running the project
- Fix script to run with sbt - Updated documentation - Remove UseCase to make things simpler
|
Hi @jczuchnowski . This PR is mainly related to addition of a ZIO based implementation. I will be glad to hear |
|
@emanueloliveira23 have got time to review it? Thanks in advance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main object of this new PR is to include a zio-based implementation of the challenge.
Therefore, the project now contains both akka (akka http) and zio (http4s) implementations.
Updated the documentation to show how to run the projects.