fix: cleanup lint warning (#1109)

* fixed all lint warning

* revert back wrong deletion

src/attachments/attachments.service.spec.ts

@@ -24,6 +24,7 @@ const mockAttachment: Attachment = {
 
 describe("AttachmentsService", () => {
   let service: AttachmentsService;
+  // eslint-disable-next-line @typescript-eslint/no-unused-vars
   let attachmentModel: Model<Attachment>;
 
   beforeEach(async () => {

src/auth/access-group-provider/access-group-from-multiple-providers.service.ts

@@ -1,4 +1,4 @@
-import { Injectable, Logger } from "@nestjs/common";
+import { Injectable } from "@nestjs/common";
 import { UserPayload } from "../interfaces/userPayload.interface";
 import { AccessGroupService } from "./access-group.service";
 
@@ -11,10 +11,7 @@ export class AccessGroupFromMultipleProvidersService extends AccessGroupService
     super();
   }
 
-  async getAccessGroups(
-    //idpPayload: Record<string, unknown>,
-    userPayload: UserPayload,
-  ): Promise<string[]> {
+  async getAccessGroups(userPayload: UserPayload): Promise<string[]> {
     const accessGroups: string[] = [];
 
     for (const accessGroupProvider of this.accessGroupProviders) {

src/auth/access-group-provider/access-group-from-static-values.service.ts

@@ -1,4 +1,4 @@
-import { Injectable, Logger } from "@nestjs/common";
+import { Injectable } from "@nestjs/common";
 import { AccessGroupService } from "./access-group.service";
 
 /**
@@ -11,10 +11,6 @@ export class AccessGroupFromStaticValuesService extends AccessGroupService {
   }
 
   async getAccessGroups(): Promise<string[]> {
-    // Logger.log(
-    //   "Static access group getAccessGroups : " +
-    //     this.staticAccessGroups.join(","),
-    // );
     return this.staticAccessGroups;
   }
 }

src/auth/auth.controller.spec.ts

@@ -4,15 +4,15 @@ import { AuthService } from "./auth.service";
 import { ConfigService } from "@nestjs/config";
 
 class AuthServiceMock {
-  login(req: Record<string, unknown>) {
+  login() {
     return { username: "Test User", email: "[email protected]" };
   }
 
-  adLogin(req: Record<string, unknown>) {
+  adLogin() {
     return { username: "Test User", email: "[email protected]" };
   }
 
-  whoami(req: Record<string, unknown>) {
+  whoami() {
     return { username: "Test User", email: "[email protected]" };
   }
 }

src/auth/guards/jwt-auth.guard.ts

@@ -1,8 +1,4 @@
-import {
-  ExecutionContext,
-  Injectable,
-  UnauthorizedException,
-} from "@nestjs/common";
+import { ExecutionContext, Injectable } from "@nestjs/common";
 import { Reflector } from "@nestjs/core";
 import { AuthGuard } from "@nestjs/passport";
 
@@ -26,8 +22,6 @@ export class JwtAuthGuard extends AuthGuard("jwt") {
     err: unknown,
     // eslint-disable-next-line @typescript-eslint/no-explicit-any
     user: any,
-    info: unknown,
-    context: ExecutionContext,
   ) {
     // const allowAny = this.reflector.get<string[]>(
     //   "allow-any",

src/auth/strategies/ldap.strategy.ts

@@ -87,7 +87,7 @@ export class LdapStrategy extends PassportStrategy(Strategy, "ldap") {
 
     const foundUser = await this.usersService.findOne(userFilter);
     const jsonUser = JSON.parse(JSON.stringify(foundUser));
-    const { password, ...user } = jsonUser;
+    const { ...user } = jsonUser;
     user.userId = user._id;
 
     // update user identity if needed

src/auth/strategies/oidc.strategy.ts

@@ -142,7 +142,7 @@ export class OidcStrategy extends PassportStrategy(Strategy, "oidc") {
     }
 
     const jsonUser = JSON.parse(JSON.stringify(user));
-    const { password, ...returnUser } = jsonUser;
+    const { ...returnUser } = jsonUser;
     returnUser.userId = returnUser._id;
 
     return returnUser;

src/common/pipes/filter.pipe.ts

@@ -1,4 +1,4 @@
-import { PipeTransform, Injectable, ArgumentMetadata } from "@nestjs/common";
+import { PipeTransform, Injectable } from "@nestjs/common";
 
 @Injectable()
 export class FilterPipe
@@ -8,10 +8,10 @@ export class FilterPipe
       { filter?: string; fields?: string }
     >
 {
-  transform(
-    inValue: { filter?: string; fields?: string },
-    metadata: ArgumentMetadata,
-  ): { filter?: string; fields?: string } {
+  transform(inValue: { filter?: string; fields?: string }): {
+    filter?: string;
+    fields?: string;
+  } {
     /*
      * intercept filter and make sure to convert loopback operators to mongo operators
      */

src/config/configuration.ts

@@ -1,4 +1,3 @@
-import { Logger } from "@nestjs/common";
 import * as fs from "fs";
 import { merge } from "lodash";
 import localconfiguration from "./localconfiguration";
@@ -58,20 +57,6 @@ const configuration = () => {
     }
   });
 
-  // Logger.log("Config SETUP");
-  // Logger.log("- Access groups statisc values : " + accessGroupsStaticValues);
-  // Logger.log("- Admin groups : " + adminGroups);
-  // Logger.log("- Delete groups : " + deleteGroups );
-  // Logger.log("- Create dataset groups : " + createDatasetGroups);
-  // Logger.log(
-  //   "- Create dataset with pid groups : " + createDatasetWithPidGroups,
-  // );
-  // Logger.log(
-  //   "- Create dataset privileged groups : " + createDatasetPrivilegedGroups,
-  // );
-  // Logger.log("- Create job groups : " + createJobGroups);
-  // Logger.log("- Update job groups : " + updateJobGroups);
-
   const config = {
     loggerConfigs: jsonConfigMap.loggers || [defaultLogger],
     adminGroups: adminGroups.split(",").map((v) => v.trim()) ?? [],

src/datablocks/datablocks.service.spec.ts

@@ -35,6 +35,7 @@ const mockDatablock: Datablock = {
 
 describe("DatablocksService", () => {
   let service: DatablocksService;
+  // eslint-disable-next-line @typescript-eslint/no-unused-vars
   let model: Model<Datablock>;
 
   beforeEach(async () => {

src/datasets/datasets.controller.ts

@@ -21,7 +21,6 @@ import {
   InternalServerErrorException,
   ConflictException,
   BadRequestException,
-  Header,
 } from "@nestjs/common";
 import { MongoError } from "mongodb";
 import {
@@ -97,7 +96,6 @@ import { TechniqueClass } from "./schemas/technique.schema";
 import { RelationshipClass } from "./schemas/relationship.schema";
 import { JWTUser } from "src/auth/interfaces/jwt-user.interface";
 import { LogbooksService } from "src/logbooks/logbooks.service";
-import { Logbook } from "src/logbooks/schemas/logbook.schema";
 import configuration from "src/config/configuration";
 import { DatasetType } from "./dataset-type.enum";
 
@@ -548,10 +546,7 @@ export class DatasetsController {
     @Req() request: Request,
     @Body() createDatasetDto: CreateRawDatasetDto | CreateDerivedDatasetDto,
   ): Promise<{ valid: boolean }> {
-    const datasetDTO = await this.checkPermissionsForDatasetCreate(
-      request,
-      createDatasetDto,
-    );
+    await this.checkPermissionsForDatasetCreate(request, createDatasetDto);
 
     const dtoTestRawCorrect = plainToInstance(
       CreateRawDatasetDto,
@@ -923,8 +918,6 @@ export class DatasetsController {
     @Headers() headers: Record<string, string>,
     @Query(new FilterPipe()) queryFilter: { filter?: string },
   ): Promise<DatasetClass | null> {
-    const user: JWTUser = request.user as JWTUser;
-
     const mergedFilters = replaceLikeOperator(
       this.updateMergedFiltersForList(
         request,
@@ -1343,7 +1336,7 @@ export class DatasetsController {
     @Req() request: Request,
     @Param("pid") pid: string,
   ): Promise<Partial<Attachment>> {
-    const dataset = await this.checkPermissionsForDatasetExtended(
+    await this.checkPermissionsForDatasetExtended(
       request,
       pid,
       Action.DatasetRead,
@@ -1439,7 +1432,7 @@ export class DatasetsController {
     @Req() request: Request,
     @Param("pid") pid: string,
   ): Promise<Attachment[]> {
-    const dataset = await this.checkPermissionsForDatasetExtended(
+    await this.checkPermissionsForDatasetExtended(
       request,
       pid,
       Action.DatasetAttachmentRead,
@@ -1483,7 +1476,7 @@ export class DatasetsController {
     @Param("aid") aid: string,
     @Body() updateAttachmentDto: UpdateAttachmentDto,
   ): Promise<Attachment | null> {
-    const dataset = await this.checkPermissionsForDatasetExtended(
+    await this.checkPermissionsForDatasetExtended(
       request,
       pid,
       Action.DatasetAttachmentUpdate,
@@ -1527,7 +1520,7 @@ export class DatasetsController {
     @Param("pid") pid: string,
     @Param("aid") aid: string,
   ): Promise<unknown> {
-    const dataset = await this.checkPermissionsForDatasetExtended(
+    await this.checkPermissionsForDatasetExtended(
       request,
       pid,
       Action.DatasetAttachmentDelete,
@@ -1637,7 +1630,7 @@ export class DatasetsController {
     @Param("pid") pid: string,
     @Body() createOrigDatablock: unknown,
   ): Promise<{ valid: boolean; errors: ValidationError[] }> {
-    const dataset = await this.checkPermissionsForDatasetExtended(
+    await this.checkPermissionsForDatasetExtended(
       request,
       pid,
       Action.DatasetOrigdatablockCreate,
@@ -1682,7 +1675,7 @@ export class DatasetsController {
     @Req() request: Request,
     @Param("pid") pid: string,
   ): Promise<OrigDatablock[]> {
-    const dataset = await this.checkPermissionsForDatasetExtended(
+    await this.checkPermissionsForDatasetExtended(
       request,
       pid,
       Action.DatasetOrigdatablockRead,
@@ -1913,7 +1906,7 @@ export class DatasetsController {
     @Req() request: Request,
     @Param("pid") pid: string,
   ): Promise<Datablock[]> {
-    const dataset = await this.checkPermissionsForDatasetExtended(
+    await this.checkPermissionsForDatasetExtended(
       request,
       pid,
       Action.DatasetDatablockRead,

src/datasets/datasets.service.spec.ts

@@ -87,6 +87,7 @@ const mockDataset: DatasetClass = {
 
 describe("DatasetsService", () => {
   let service: DatasetsService;
+  // eslint-disable-next-line @typescript-eslint/no-unused-vars
   let model: Model<DatasetClass>;
 
   beforeEach(async () => {

src/elastic-search/elastic-search.service.ts

@@ -9,7 +9,6 @@ import {
 import { Client } from "@elastic/elasticsearch";
 import { SearchQueryService } from "./providers/query-builder.service";
 import {
-  SearchTotalHits,
   SearchRequest,
   AggregationsAggregate,
   SortOrder,

src/initial-datasets/initial-datasets.service.spec.ts

@@ -10,6 +10,7 @@ const mockInitialDataset: InitialDataset = {
 
 describe("InitialDatasetsService", () => {
   let service: InitialDatasetsService;
+  // eslint-disable-next-line @typescript-eslint/no-unused-vars
   let initialDatasetModel: Model<InitialDataset>;
 
   beforeEach(async () => {

src/instruments/instruments.service.spec.ts

@@ -14,6 +14,7 @@ const mockInstrument: Instrument = {
 
 describe("InstrumentsService", () => {
   let service: InstrumentsService;
+  // eslint-disable-next-line @typescript-eslint/no-unused-vars
   let model: Model<Instrument>;
 
   beforeEach(async () => {

src/jobs/jobs.service.spec.ts

@@ -30,6 +30,7 @@ class PoliciesServiceMock {}
 
 describe("JobsService", () => {
   let service: JobsService;
+  // eslint-disable-next-line @typescript-eslint/no-unused-vars
   let model: Model<JobClass>;
 
   beforeEach(async () => {

src/origdatablocks/origdatablocks.service.spec.ts

@@ -32,6 +32,7 @@ const mockOrigDatablock: OrigDatablock = {
 
 describe("OrigdatablocksService", () => {
   let service: OrigDatablocksService;
+  // eslint-disable-next-line @typescript-eslint/no-unused-vars
   let model: Model<OrigDatablock>;
 
   beforeEach(async () => {

src/policies/policies.service.spec.ts

@@ -33,6 +33,7 @@ const mockPolicy: Policy = {
 
 describe("PoliciesService", () => {
   let service: PoliciesService;
+  // eslint-disable-next-line @typescript-eslint/no-unused-vars
   let policyModel: Model<Policy>;
 
   beforeEach(async () => {

src/proposals/proposals.service.spec.ts

@@ -30,6 +30,7 @@ const mockProposal: ProposalClass = {
 
 describe("ProposalsService", () => {
   let service: ProposalsService;
+  // eslint-disable-next-line @typescript-eslint/no-unused-vars
   let model: Model<ProposalClass>;
 
   beforeEach(async () => {

src/proposals/schemas/proposal.schema.ts

@@ -1,10 +1,7 @@
 import { Prop, Schema, SchemaFactory } from "@nestjs/mongoose";
-import { ApiProperty, getSchemaPath } from "@nestjs/swagger";
+import { ApiProperty } from "@nestjs/swagger";
 import { Document } from "mongoose";
-import {
-  Attachment,
-  AttachmentSchema,
-} from "src/attachments/schemas/attachment.schema";
+
 import { OwnableClass } from "src/common/schemas/ownable.schema";
 import {
   MeasurementPeriodClass,

src/published-data/published-data.controller.ts

@@ -439,8 +439,7 @@ export class PublishedDataController {
     @Param("id") id: string,
     @Body() data: UpdatePublishedDataDto,
   ): Promise<IRegister | null> {
-    // eslint-disable-next-line @typescript-eslint/naming-convention
-    const { doi, ...publishedData } = data;
+    const { ...publishedData } = data;
 
     const OAIServerUri = this.configService.get<string>("oaiProviderRoute");
 

src/published-data/published-data.service.spec.ts

@@ -32,6 +32,7 @@ const mockPublishedData: PublishedData = {
 
 describe("PublishedDataService", () => {
   let service: PublishedDataService;
+  // eslint-disable-next-line @typescript-eslint/no-unused-vars
   let model: Model<PublishedData>;
 
   beforeEach(async () => {

src/published-data/published-data.service.ts

@@ -2,7 +2,7 @@ import { Inject, Injectable, Scope } from "@nestjs/common";
 import { REQUEST } from "@nestjs/core";
 import { Request } from "express";
 import { InjectModel } from "@nestjs/mongoose";
-import { FilterQuery, Model, QueryOptions } from "mongoose";
+import { FilterQuery, Model } from "mongoose";
 import {
   parseLimitFilters,
   addCreatedByFields,

src/samples/samples.controller.ts

@@ -63,7 +63,6 @@ import { Request } from "express";
 import { JWTUser } from "src/auth/interfaces/jwt-user.interface";
 import { IDatasetFields } from "src/datasets/interfaces/dataset-filters.interface";
 import { CreateSubAttachmentDto } from "src/attachments/dto/create-sub-attachment.dto";
-import { User } from "src/users/schemas/user.schema";
 
 @ApiBearerAuth()
 @ApiTags("samples")

src/samples/samples.service.spec.ts

@@ -43,6 +43,7 @@ const mockSample: SampleClass = {
 
 describe("SamplesService", () => {
   let service: SamplesService;
+  // eslint-disable-next-line @typescript-eslint/no-unused-vars
   let sampleModel: Model<SampleClass>;
 
   beforeEach(async () => {

src/samples/samples.service.ts

@@ -31,6 +31,7 @@ export class SamplesService {
     const createdSample = new this.sampleModel(
       addCreatedByFields(createSampleDto, username),
     );
+
     return createdSample.save();
   }
 

src/users/roles.service.spec.ts

@@ -19,7 +19,9 @@ const mockUserRole: UserRole = {
 
 describe("RolesService", () => {
   let service: RolesService;
+  // eslint-disable-next-line @typescript-eslint/no-unused-vars
   let roleModel: Model<Role>;
+  // eslint-disable-next-line @typescript-eslint/no-unused-vars
   let userRoleModel: Model<UserRole>;
 
   beforeEach(async () => {

src/users/user-identities.service.spec.ts

@@ -25,6 +25,7 @@ const mockUserIdentity: UserIdentity = {
 
 describe("UserIdentitiesService", () => {
   let service: UserIdentitiesService;
+  // eslint-disable-next-line @typescript-eslint/no-unused-vars
   let userIdentityModel: Model<UserIdentity>;
 
   beforeEach(async () => {