Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data preparation functionalities #57

Merged
merged 29 commits into from
Aug 7, 2024
Merged

Data preparation functionalities #57

merged 29 commits into from
Aug 7, 2024

Conversation

nitrosx
Copy link
Contributor

@nitrosx nitrosx commented Aug 1, 2024

This PR implements the following:

  • updating schemas
  • create data structures locally with correct values
  • implements functions to place calls to the SciCat API endpoint

@nitrosx nitrosx requested a review from YooSunYoung August 1, 2024 11:30
@nitrosx
Copy link
Contributor Author

nitrosx commented Aug 1, 2024

@YooSunYoung
I apologies for the huge PR, but this is now ready to be reviewed and for to brainstorm about it

YooSunYoung
YooSunYoung requested changes Aug 6, 2024
View reviewed changes
src/scicat_online_ingestor.py Outdated Show resolved Hide resolved
src/scicat_online_ingestor.py Outdated Show resolved Hide resolved
src/scicat_online_ingestor.py Show resolved Hide resolved
src/scicat_offline_ingestor.py Outdated Show resolved Hide resolved
src/scicat_offline_ingestor.py Outdated Show resolved Hide resolved
src/scicat_offline_ingestor.py Show resolved Hide resolved
resources/config.sample.json Show resolved Hide resolved
src/scicat_schemas/dataset.schema.json.jinja Outdated Show resolved Hide resolved
@YooSunYoung
Merge pull request #61 from SciCatProject/refactor-scicat-dataset
a927869 
Refactor scicat dataset instance creation.
@YooSunYoung
Merge pull request #62 from SciCatProject/refactor-communication
14d4682 
Refactor scicat backend communication helpers.
@YooSunYoung YooSunYoung marked this pull request as ready for review August 7, 2024 15:41
@YooSunYoung YooSunYoung merged commit 4dc97d4 into main Aug 7, 2024
3 checks passed
@YooSunYoung YooSunYoung deleted the data-preparation branch August 7, 2024 15:41
@YooSunYoung
Copy link
Contributor

I'll merge this here and continue working on top of that : D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YooSunYoung YooSunYoung YooSunYoung approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nitrosx @YooSunYoung