Add experimental ScicatClient.query_datasets #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jl-wynen
force-pushed
the
dataset-query
branch
2 times, most recently
from
4214015
to
b62b300
Compare
|
What's the status on this? Are we still waiting for some things to be fixed/clarified on the scicat end? @nitrosx any input? |
|
I'm still waiting for clarification / fixes. Especially about which fields are supported and what is the syntax since that seems to have changed back and forth. |
nvaytet
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First attempt at solving #177
This is meant as a prototype to try out a simple query syntax. As the docstring says, I am open to changing the interface in the future. But this version should be enough to get some users going with querying and we can improve when we have experience with it and a better idea of where SciCat is headed.
I only added it in the low-level
ScicatClientbecause of the questions raised in #177 about the performance implications of buildingDatasetobjects.