switch diffeqoperators to scimloperators #870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisRackauckas
approved these changes
Feb 6, 2023
This was referenced Feb 6, 2023
|
will rerun CI once downstream PRs are merged. maybe we get some more issues. |
|
rerunning CI |
|
Don't you want to wait for JuliaRegistries/General#77143 ? |
|
haha yes. i was just playing to see how long it would take before GH picks up the merge. |
|
https://github.com/SciML/DiffEqBase.jl/actions/runs/4108922303/jobs/7090163844#step:6:1143 Looks like DiffEqOperators needs to be setup for backwards compatibility first. |
|
Yes - glad we're catching all the downstream packages that need to be updated |
ChrisRackauckas
approved these changes
Feb 8, 2023
|
Weird, it's still picking up the old version of Sundials and OrdinaryDiffEq with DiffEqOperators. |
This was referenced Feb 9, 2023
|
same delaydiffeq failing here due to accuracy. rerunning |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
plan: SciML/SciMLOperators.jl#142
In
test/basic_operator_tests.jl, test/affine_operator_tests.jl, there are tests for DiffEqOperators. Let's leave that as it is till DiffEqOps are remove from downstream packages.