Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make remake_buffer work for array symbolics #79

Merged
merged 2 commits into from
May 28, 2024

Conversation

AayushSabharwal
Copy link
Member

@AayushSabharwal AayushSabharwal commented May 22, 2024

Close SciML/ModelingToolkit.jl#2713

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

Copy link

codecov bot commented May 22, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 85.79%. Comparing base (71408bb) to head (f5e96c6).

Files Patch % Lines
src/remake.jl 80.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #79      +/-   ##
==========================================
- Coverage   86.15%   85.79%   -0.37%     
==========================================
  Files          11       11              
  Lines         513      521       +8     
==========================================
+ Hits          442      447       +5     
- Misses         71       74       +3     
Flag Coverage Δ
docs 28.07% <0.00%> (-0.45%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisRackauckas ChrisRackauckas merged commit d0f4433 into master May 28, 2024
7 of 13 checks passed
@ChrisRackauckas ChrisRackauckas deleted the as/remake-buffer-arraysym branch May 28, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using mixed data types with the remake function will lead to an error.
2 participants