Dev minor #1480
Closed
Dev minor #1480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* up * up * add back database * merge * merge
* removing prompt provider * migrate prompt provider
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
* Update pyproject.toml (#1471) * add alembic migrations to pypi release (#1472) * add alembic migrations to pypi release * modify path * run on main (#1474) * minor kg-search bug (#1476) * minor kg-search bug * fix * Update pyproject.toml * Move to psycopg binary (#1477) --------- Co-authored-by: Shreyas Pimpalgaonkar <[email protected]> Co-authored-by: Nolan Tremelling <[email protected]>
* check in * Finish ingest chunks, delete, and testing * Docs and JS tests
* Update pyproject.toml (#1471) * add alembic migrations to pypi release (#1472) * add alembic migrations to pypi release * modify path * run on main (#1474) * minor kg-search bug (#1476) * minor kg-search bug * fix * Update pyproject.toml * Move to psycopg binary (#1477) * Ensure that we retrieve KG Status for documents in collection * github sucks --------- Co-authored-by: emrgnt-cmplxty <[email protected]> Co-authored-by: Shreyas Pimpalgaonkar <[email protected]>
* Update pyproject.toml (#1471) * add alembic migrations to pypi release (#1472) * add alembic migrations to pypi release * modify path * run on main (#1474) * minor kg-search bug (#1476) * minor kg-search bug * fix * Update pyproject.toml * Move to psycopg binary (#1477) --------- Co-authored-by: Shreyas Pimpalgaonkar <[email protected]> Co-authored-by: Nolan Tremelling <[email protected]>
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 9633f00 in 2 minutes and 14 seconds
More details
- Looked at
9313lines of code in120files - Skipped
1files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. py/core/providers/database/file.py:191
- Draft comment:
Ensure 'lobject' is defined before attempting to close it to avoid potential errors if 'lo_open' fails.
if 'lobject' in locals():
await conn.execute("SELECT lo_close($1)", lobject)
- Reason this comment was not posted:
Comment did not seem useful.
Workflow ID: wflow_fOCu6CvgwpsZ3EKK
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
This pull request adds chunk management functionalities, including ingestion, updating, and deletion, along with corresponding tests and configuration updates.
update_chunksmethod inIngestionMixinsto update chunk content and metadata.runner_sdk.py.test_ingest_chunks,test_update_chunks, andtest_delete_chunksinrunner_sdk.py.test_file_provider.pyto usepostgres_db_providerfor file operations.test_kg_logic.py.conftest.pyto include new fixtures for database and provider configurations.openai_providerfixture inembedding/conftest.py.This description was created by
for 9633f00. It will automatically update as commits are pushed.