Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ProjectBusy endpoint #1446

Merged
merged 14 commits into from
Aug 7, 2023

Conversation

i-oden
Copy link
Member

@i-oden i-oden commented Jul 24, 2023

Before submitting this PR

  1. Description: In a previous version the DDS set projects to busy when upload or download was ongoing. Now, we have remove that from the CLI, but some users seem to have skipped any upgrades, and therefore some projects are getting stuck in "busy" status which is blocking the project from any actions. This means we sometimes have to manually change the busy status in the database for certain projects when this happens. We need to avoid this issue in the future, we could spend our time on something a lot more useful.
  2. Jira task / GitHub issue: DDS-1613
  3. How to test: Add information on how someone could manually test this functionality. As detailed as possible.
  4. Type of change: Check the relevant boxes in the section below
  5. Add docstrings and comments to code, even if you personally think it's obvious.

What type of change(s) does the PR contain?

  • New feature
    • Breaking
    • Non-breaking
  • Database change
    • Migration included in PR
    • Migration not needed
  • Bug fix
    • Breaking: Please describe the reason for the break and how we can fix it.
    • Non-breaking
  • Security Alert fix
  • Documentation
  • Tests (only)
  • Workflow

Checklist

  • Sprintlog
    • Added
    • Not needed (E.g. PR contains only tests)
  • Rebase / Update / Merge from base branch (the branch from which the current is forked)
    • Done
    • Not needed
  • Blocking PRs
    • Merged
    • No blocking PRs
  • PR to master branch

Actions / Scans

  • Black: Python code formatter. Does not execute. Only tests.
    Run black . locally to execute formatting.
    • Passed
  • Prettier: General code formatter. Our use case: MD and yaml mainly.
    Run npx prettier --write . locally to execute formatting.
    • Passed
  • Yamllint: Linting of yaml files.
    • Passed
  • Tests: Pytest to verify that functionality works as expected.
    • New tests added
    • No new tests
    • Passed
  • CodeQL: Scan for security vulnerabilities, bugs, errors
    • New alerts: Go through them and either fix, dismiss och ignore. Add reasoning in items below.
    • Alerts fixed: What?
    • Alerts ignored / dismissed: Why?
    • Passed
  • Trivy: Security scanner
    • New alerts: Go through them and either fix, dismiss och ignore. Add reasoning in items below.
    • Alerts fixed: What?
    • Alerts ignored / dismissed: Why?
    • Passed
  • Snyk: Security scanner
    • New alerts: Go through them and either fix, dismiss och ignore. Add reasoning in items below.
    • Alerts fixed: What?
    • Alerts ignored / dismissed: Why?
    • Passed

@i-oden i-oden self-assigned this Jul 24, 2023
@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Merging #1446 (5fe11c7) into dev (f82c7da) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

❗ Current head 5fe11c7 differs from pull request most recent head f870c30. Consider uploading reports for the commit f870c30 to get more accurate results

@@            Coverage Diff             @@
##              dev    #1446      +/-   ##
==========================================
- Coverage   89.42%   89.39%   -0.04%     
==========================================
  Files          29       29              
  Lines        4314     4298      -16     
==========================================
- Hits         3858     3842      -16     
  Misses        456      456              
Files Changed Coverage Δ
dds_web/api/project.py 89.76% <100.00%> (-0.35%) ⬇️

@i-oden i-oden marked this pull request as ready for review July 24, 2023 15:31
@i-oden i-oden requested a review from valyo July 24, 2023 15:31
@i-oden i-oden marked this pull request as draft July 24, 2023 16:01
@i-oden i-oden marked this pull request as ready for review July 26, 2023 06:38
Copy link
Member

@valyo valyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Tested by checking out v2.1.0 and trying an upload, resulting in error message as intended.

@i-oden i-oden merged commit 097fc1a into dev Aug 7, 2023
11 checks passed
@i-oden i-oden deleted the DDS-1613-remove-the-busy-status-endpoint-from-the-api branch August 7, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants