Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alert unit email and us if storage threshold reached #1562

Open
wants to merge 22 commits into
base: dev
Choose a base branch
from

Conversation

rv0lt
Copy link
Member

@rv0lt rv0lt commented Oct 11, 2024

Read this before submitting the PR

  1. Always create a Draft PR first
  2. Go through sections 1-5 below, fill them in and check all the boxes
  3. Make sure that the branch is updated; if there's an "Update branch" button at the bottom of the PR, rebase or update branch.
  4. When all boxes are checked, information is filled in, and the branch is updated: mark as Ready For Review and tag reviewers (top right)
  5. Once there is a submitted review, implement the suggestions (if reasonable, otherwise discuss) and request an new review.

If there is a field which you are unsure about, enter the edit mode of this description or go to the PR template; There are invisible comments providing descriptions which may be of help.

1. Description / Summary

Modifgy the monitor usage command to send an email to both the unit affected and our team in case the warning level is surpassed

2. Jira task / GitHub issue

Link to the github issue or add the Jira task ID here.

3. Type of change

What type of change(s) does the PR contain?

Check the relevant boxes below. For an explanation of the different sections, enter edit mode of this PR description template.

  • New feature
    • Breaking: Why / How? Add info here.
    • Non-breaking
  • Database change: Remember the to include a new migration version, or explain here why it's not needed.
  • Bug fix
  • Security Alert fix
    • Package update
      • Major version update
  • Documentation
  • Workflow
  • Tests only

4. Additional information

5. Actions / Scans

Check the boxes when the specified checks have passed.

For information on what the different checks do and how to fix it if they're failing, enter edit mode of this description or go to the PR template.

  • Black
  • Prettier
  • Yamllint
  • Tests
  • CodeQL
  • Trivy
  • Snyk

@rv0lt rv0lt self-assigned this Oct 11, 2024
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.53%. Comparing base (f6aa2d1) to head (b030727).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1562   +/-   ##
=======================================
  Coverage   92.53%   92.53%           
=======================================
  Files          29       29           
  Lines        4878     4879    +1     
=======================================
+ Hits         4514     4515    +1     
  Misses        364      364           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rv0lt rv0lt marked this pull request as ready for review October 16, 2024 13:50
@rv0lt rv0lt requested a review from a team as a code owner October 16, 2024 13:50
@rv0lt rv0lt requested review from a team and removed request for a team October 16, 2024 14:29
@rv0lt rv0lt removed the request for review from a team October 18, 2024 07:47
Copy link
Member

@i-oden i-oden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quick note -- add a description to the PR

@valyo
Copy link
Member

valyo commented Oct 23, 2024

Also, the title says "instead", and it should be "Alert unit and us..." or something like that

@rv0lt rv0lt marked this pull request as draft October 23, 2024 07:21
@rv0lt rv0lt changed the title Alert unit email instead of us if storage threshold reached Alert unit email and us if storage threshold reached Oct 23, 2024
SPRINTLOG.md Outdated Show resolved Hide resolved
@rv0lt rv0lt requested a review from i-oden October 24, 2024 07:31
@rv0lt rv0lt marked this pull request as ready for review October 24, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants