Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InvalidJWEData #1572

Open
wants to merge 9 commits into
base: dev
Choose a base branch
from
Open

InvalidJWEData #1572

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c359828
catched invalid token
rv0lt Nov 5, 2024
274ff70
sprintlog
rv0lt Nov 5, 2024
2eacf83
general exception
rv0lt Nov 5, 2024
cf3981b
ununsed package
rv0lt Nov 5, 2024
53b6593
simpler solution
rv0lt Nov 7, 2024
4a1cef0
log the exp as an error only printing the name for possible debug pur…
rv0lt Nov 7, 2024
1f39157
typo
rv0lt Nov 7, 2024
8bd2ca9
typo
rv0lt Nov 7, 2024
d60dab3
Update SPRINTLOG.md
rv0lt Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions SPRINTLOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,3 +450,7 @@ _Nothing merged during this sprint_
- Workflow: Bump GitHub checkout action to v4 ([#1556](https://github.com/ScilifelabDataCentre/dds_web/pull/1556))
- Workflow: CodeQL action version(s) bumped to v3 ([#1569](https://github.com/ScilifelabDataCentre/dds_web/pull/1569))
- Workflow: Setup-node, codecov and upload-sarif action versions bumped to v4, v4 and v3, respectively ([#1570](https://github.com/ScilifelabDataCentre/dds_web/pull/1570))

# 2024-11-04 - 2024-11-15

- Removed exception for invalid token to simplify logging and reduce unnecessary error entries ([#1572](https://github.com/ScilifelabDataCentre/dds_web/pull/1572))
2 changes: 1 addition & 1 deletion dds_web/security/auth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,7 @@ def __verify_general_token(token):
# ValueError is raised when the token doesn't look right (for example no periods)
# jwcryopto.common.JWException is the base exception raised by jwcrypto,
# and is raised when the token is malformed or invalid.
flask.current_app.logger.exception(e)
flask.current_app.logger.warning(f"Error with Token operation: {type(e).__name__}")
raise AuthenticationError(message="Invalid token") from e

expiration_time = data.get("exp")
Expand Down