Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

godot: default to console #14268

Merged
merged 1 commit into from
Dec 29, 2024
Merged

godot: default to console #14268

merged 1 commit into from
Dec 29, 2024

Conversation

gsuuon
Copy link
Contributor

@gsuuon gsuuon commented Oct 21, 2024

This defaults godot to the console binary. I found it strange that godot --help did nothing - since scoop is a terminal installer I think being console-first makes sense. If this is too breaking (not sure if anyone's depending on that behavior) we could also just add godot-cli as the console alias.

Closes: #13248
Related: #13484 (draft) -- I don't address portability in this PR

Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

godot

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

Copy link
Member

@rasa rasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call: all bin commands should be CLI, GUIs live in shortcuts.

@rasa rasa merged commit bfed0f5 into ScoopInstaller:master Dec 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Godot Installation running in the background
2 participants