feat: add watch for announcements and local testing #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcomariscal
changed the base branch from
main
to
feat/fetch-announcement-for-user
Closed
garyghayrat
reviewed
Mar 11, 2024
garyghayrat
reviewed
Mar 11, 2024
garyghayrat
reviewed
Mar 14, 2024
garyghayrat
reviewed
Mar 14, 2024
garyghayrat
reviewed
Mar 14, 2024
package.json
Outdated
| @@ -6,9 +6,13 @@ | |||
| "module": "dist/index.js", | |||
| "type": "module", | |||
| "scripts": { | |||
| "anvil-local": "make anvil-local", | |||
There was a problem hiding this comment.
Can't we put the make file commands directly here and get rid of the makefile.
|
marcomariscal
changed the base branch from
feat/fetch-announcement-for-user
to
main
marcomariscal
changed the base branch from
main
to
feat/fetch-announcement-for-user
marcomariscal
changed the base branch from
feat/fetch-announcement-for-user
to
main
garyghayrat
changed the base branch from
main
to
feat/fetch-announcement-for-user
--------- Co-authored-by: Gary Ghayrat <[email protected]>
garyghayrat
force-pushed
the
feat/watch-for-announcements
branch
from
a85018a to
c59d441
Compare
garyghayrat
changed the base branch from
feat/fetch-announcement-for-user
to
main
garyghayrat
changed the title
garyghayrat
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
watch for announcements and assess if it's for the user.
also updates the tests to use a local fork when appropriate.