Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed tooltip border and added course button color on dark mode #212

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

joharkhan99
Copy link
Contributor

Description

Fixed tooltip border by adding dark: class and added course button color on dark mode with dark mode tailwind CSS class.

Closes #207

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

checked and confirmed the changes on the frontend course cards.

Test Configuration:

  • Desktop/Mobile:
  • Browser:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link

vercel bot commented Feb 4, 2025

@joharkhan99 is attempting to deploy a commit to the ScottyLabs Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Feb 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cmucourses-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2025 4:18am

Copy link
Member

@Xavilien Xavilien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for working on this!

@Xavilien Xavilien merged commit 2802b66 into ScottyLabs:main Feb 5, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Incorrect styles for add course button on dark mode
2 participants