style: smoother loading experience #549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
cirex-web
commented
Feb 2, 2025
| "react/jsx-uses-react": "error", | ||
| "react/jsx-uses-vars": "error", | ||
| "react/prop-types": "off", | ||
| "react/require-default-props": "off", // we don't use prop-types for prop validation https://stackoverflow.com/a/64041197/13171687 |
There was a problem hiding this comment.
the only diff here is line 28
GhostOf0days
approved these changes
Feb 9, 2025
|
@cirex-web my bad bro. i didn't see the branch this was merging into. |
GhostOf0days
added a commit
that referenced
this pull request
Feb 9, 2025
This reverts commit 2788bed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Video demo, with and without an artificial 5s delay from the API (note how the loading screen doesn't appear in the second case)
Screen.Recording.2025-02-02.at.5.18.29.PM.mov
This has not gone through the design team, but I like it lol