Fixed thread group cap and randomised seed not working on GPU #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error where offset is not accounted for
MrSmokedSalmon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIX #1 TERRAIN SIZE LIMIT WHEN USING COMPUTE SHADER FOR TERRAIN GENERATION
Fixed a problem where the size of the terrain would exceed the maximum number of threads allowed. This error broke terrain generation using the compute shader on any terrain larger than 249x249.
New fix implements a method of multiple dispatches of the compute shader and allows for terrain of any size, limited by hardware capabilities.
FIX #2 SEED NOT RANDOMISING ON COMPUTE SHADER TERRAIN GENERATION
Fixed a problem where the seeds would not get randomised when using the compute shader.
New fix adds a missing line of code found in the C# terrain generation method.