-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support SQLAlchemy 2.0.x #160
Conversation
Signed-off-by: Ahmad Wahid <[email protected]>
Signed-off-by: Ahmad Wahid <[email protected]>
Signed-off-by: Ahmad Wahid <[email protected]>
Signed-off-by: Ahmad Wahid <[email protected]>
Signed-off-by: Ahmad Wahid <[email protected]>
Great work! I noticed that this PR constitutes a breaking change, as timely-beliefs will effectively require But before we do so, I want to ask @nhoening whether we'd need to (or prefer to) support both major versions for a while? My thought is that we'd accept breaking support for |
I agree with the plan. It is not a classic breaking change, unless someone needs to use SQLAlchemy<2 for some reason. Nevertheless, a good time to move TB to v2 |
Signed-off-by: F.N. Claessen <[email protected]>
I would want to test this when flexmeasures support |
Locally I didn't notice much of a difference, but let me know if you need anything from me to do this test properly (such as a dev release). |
In this pull request, I've advanced the SQLAlchemy version from
1.3.19
to2.0.0
and adjusted the queries to adhere to the2.0.x
format. I have used pytest to test all the new changes.References: