-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore/upgrade dependencies #188
Conversation
Signed-off-by: F.N. Claessen <[email protected]>
Signed-off-by: F.N. Claessen <[email protected]>
Signed-off-by: F.N. Claessen <[email protected]>
Signed-off-by: F.N. Claessen <[email protected]>
Signed-off-by: F.N. Claessen <[email protected]>
… order as the listing Signed-off-by: F.N. Claessen <[email protected]>
Signed-off-by: F.N. Claessen <[email protected]>
Signed-off-by: F.N. Claessen <[email protected]>
Signed-off-by: F.N. Claessen <[email protected]>
Signed-off-by: F.N. Claessen <[email protected]>
Signed-off-by: F.N. Claessen <[email protected]>
Signed-off-by: F.N. Claessen <[email protected]>
Signed-off-by: F.N. Claessen <[email protected]>
Signed-off-by: F.N. Claessen <[email protected]>
…everything with share dependencies Signed-off-by: F.N. Claessen <[email protected]>
Signed-off-by: F.N. Claessen <[email protected]>
Signed-off-by: F.N. Claessen <[email protected]>
Signed-off-by: F.N. Claessen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the 3.11 test, I see many errors saying " KeyError: "DataFrame should contain column named 'source'.""
…se `np.nan` instead. Signed-off-by: F.N. Claessen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are no dev/3.10/requirements.txt, dev/3.8/requirements.txt or dev/3.7/requirements.txt
Maybe I am overlooking something but why do the tests for these Python versions not fail on that?
Mh, #177 is already closed? |
This reverts commit c574364.
The pipeline doesn't install the dev requirements, but decides what to install based on the |
I had closed it by addressing the issue in #178, which pinned Pandas. I thought I could unpin it in this PR, but alas. It turns out that for some reason my local Python 3.11 tests run different dependency versions than the GitHub pipeline. I'm still not sure why. The pipeline just runs FYI, I had asked you to review just before I realized that the pipeline wasn't checking 3.11 yet. After I added 3.11 to the pipeline, I realized that Pandas still needs a pin. Tests now pass, but unfortunately, pinning Pandas also means |
Pandas needs a on only for 3.11? |
What? |
Sorry. Is the pin only needed for 3.11? |
Ah I see, because only that version failed the tests. Well, I could test for 3.12, too, perhaps. And for <3.11 it seems we could let the pin loose indeed. |
Signed-off-by: F.N. Claessen <[email protected]>
Signed-off-by: F.N. Claessen <[email protected]>
This reverts commit e9ffb4d.
Sorry, it doesn't look like I can let go the pin on |
Well, at least that is very recent. |
Oh yeah, pandas 2.2.1 is from February, and even 2.2.2 is from April |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we not update the 3.9 requirements? It seems it uses vastly different versions (e.g. looking at pandas)
Pandas 2.2.2 is the first one compatible with numpy 2, but it breaks metadata propagation for our subclasses. Updating dev requirements is not meant to be part of this PR. |
Improve dependency management, and unpin some requirements for optional dependencies.