Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a method for missing voices #538

Merged
merged 4 commits into from
Jan 19, 2025
Merged

Conversation

shinich39
Copy link
Contributor

Find missing voices from asset list.

Description

Add utils/voiceFinder.ts
If the TalkData has voice data, fix voice url after creating the url in useProcessedScenarioData()

Related Issue

#536

Motivation and Context

For a perfect story reading.

How Has This Been Tested?

  • Chrome (Desktop)
  • Chrome (Mobile)
  • Firefox (Desktop)
  • Firefox (Mobile)
  • Safari (Desktop, optional)
  • Safari (iPhone, optional)
  • Safari (iPad, optional)

Screenshots (if appropriate):

Copy link
Contributor

@dnaroma dnaroma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove package-lock.json as we are using pnpm as package manager, it was set by corepack

@dnaroma dnaroma enabled auto-merge (rebase) January 19, 2025 15:00
@dnaroma dnaroma merged commit 616f82c into Sekai-World:dev Jan 19, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants