-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add search input and keyboard shortcuts #31
Conversation
Modify rating to initialRating during initialization
* Load json from src/metadata.json. * Add keyboard shortcuts.
Checkin |
Changing the location a little bit but keeping it the same. |
Keyboard shortcuts appear to be borked, related to zuriby/jquery.hotkeys#45 |
I am seeing this only on the welcome page (index.html); not able to reproduce with any other page. Are you seeing same? |
Yeah. I also notice swapping to |
I'm working on this... From results so far I think there is a bug in it may be that it seems to operate under the assumption that it is the only Will have to look into if there is something about the semantic docs ui On Mon, Apr 6, 2015 at 10:45 AM, Jack Lukic [email protected]
|
I think using a different library is probably ideal. That ones pretty old |
That's probably a good call. I was just looking at Mousetrap myself. You want me to make the change? Also, if you do to a fixed left sidebar layout, you may not need the search function at all. But it does show off the feature nicely. |
Is it ok if I ping you in a couple days. I want to get all the moving parts of the design out of the way before asking for a PR. |
yep |
<div class="title item">
with<div class="search item">
that contains asearch input item
. The html.eco file statically initializes the placeholder to the document.title. This is a little sneaky as it is not obvious that this element is a search input, but maintains the appearance of the existing UI without sacrificing real estate in the fixed menu bar; this could be changed to a dedicated separate item in the menu if desired.$('search')
input element to initialize the search functionality the first time a user focuses the search input.$.getJSON('src/metadata.json')
, which is generated by thegulp build-docs
command.s
(focus the search input) and?
(show a small modal describing the shortcuts) and adds dependency onjquery.hotkeys.js
.