Skip to content

Commit

Permalink
Remove deprecated mediawiki.api.parse alias (#71)
Browse files Browse the repository at this point in the history
  • Loading branch information
@kghbln @mwjames
kghbln authored and mwjames committed Aug 4, 2019
1 parent fdc6a28 commit e6a6bfd
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions SemanticCite.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -100,8 +100,7 @@ public static function initExtension( $credits = [] ) {
'onoi.qtip',
'onoi.blobstore',
'onoi.util',
'ext.scite.styles',
'mediawiki.api.parse'
'ext.scite.styles'
],
'messages' => [
'sci-tooltip-citation-lookup-failure',
Expand Down

10 comments on commit e6a6bfd

@kghbln
Copy link
Member Author

@kghbln kghbln commented on e6a6bfd Aug 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mwjames Such a tiny change creating such an utter mess. On sm-w.o the hover cards for citations do not longer work due to "api.parse" is not a function in JavaScript. I am pretty sure that this caused the issue. :(

@mwjames
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kghbln Replace mediawiki.api.parse with mediawiki.api, so I'm guessing mediawiki.api needs to be in this list.

@kghbln
Copy link
Member Author

@kghbln kghbln commented on e6a6bfd Aug 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mwjames Unfortunately this does not help. The error stays the same.

@mwjames
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just made this screenshot, do we talk about the same thing?

image

@kghbln
Copy link
Member Author

@kghbln kghbln commented on e6a6bfd Aug 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but I am having issues on s-mw.o. It just endlessly loads and issues this error. Have not looked at sandbox at all.

@mwjames
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but I am having issues on s-mw.o. I

Now I get you, well according to the WMF developer this shouldn't happen as far as I understand from the comments in regards to the api.parse alias.

image

@kghbln
Copy link
Member Author

@kghbln kghbln commented on e6a6bfd Aug 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

omg

@mwjames
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm I right to guess that adding back mediawiki.api.parse resolves the issue? If so, then this is a problem of MediaWiki of somehow not recognizing the alias, under the assumption that mediawiki.api has an alias for mediawiki.api.parse to be available on MW 1.31.

@kghbln
Copy link
Member Author

@kghbln kghbln commented on e6a6bfd Aug 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm I right to guess that adding back mediawiki.api.parse resolves the issue?

Yes, this indeed resolves the issue. This affects all software so we will have to add it again in SMW etc.

@kghbln
Copy link
Member Author

@kghbln kghbln commented on e6a6bfd Aug 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I asked about this here

Please sign in to comment.