style: fix various issues raised by phpcs

SemanticMediaWiki · Oct 25, 2024 · d3e3400 · d3e3400
1 parent 495ef7c
commit d3e3400
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 12 deletions.
diff --git a/src/PropertyAnnotators/LinksToPropertyAnnotator.php b/src/PropertyAnnotators/LinksToPropertyAnnotator.php
@@ -14,15 +14,15 @@
  * @private
  * @ingroup SESP
  *
- * @license GNU GPL v2+
+ * @license GPL-2.0-or-later
  * @since 3.0.4
  */
 class LinksToPropertyAnnotator implements PropertyAnnotator {
 
 	/**
 	 * Predefined property ID
 	 */
-	const PROP_ID = '___LINKSTO';
+	public const PROP_ID = '___LINKSTO';
 
 	/**
 	 * @var AppFactory
@@ -53,7 +53,7 @@ public function setEnabledNamespaces( array $namespaces ) {
 	 * {@inheritDoc}
 	 */
 	public function isAnnotatorFor( DIProperty $property ) {
-		return $property->getKey() === self::PROP_ID ;
+		return $property->getKey() === self::PROP_ID;
 	}
 
 	/**
@@ -64,7 +64,11 @@ public function isAnnotatorFor( DIProperty $property ) {
 	public function addAnnotation( DIProperty $property, SemanticData $semanticData ) {
 		$page = $semanticData->getSubject()->getTitle();
 
-		if ( $page === null || ( !empty( $this->enabledNamespaces ) && !$page->inNamespaces( $this->enabledNamespaces ) ) ) {
+		if (
+			$page === null ||
+			( !empty( $this->enabledNamespaces ) &&
+			!$page->inNamespaces( $this->enabledNamespaces ) )
+		) {
 			return;
 		}
 
@@ -89,7 +93,7 @@ public function addAnnotation( DIProperty $property, SemanticData $semanticData
 			[ 'page' => [ 'JOIN', 'page_id=pl_from' ] ]
 		);
 
-		foreach( $res as $row ) {
+		foreach ( $res as $row ) {
 			$title = Title::newFromText( $row->sel_title, $row->sel_ns );
 			if ( $title !== null && $title->exists() ) {
 				$semanticData->addPropertyObjectValue( $property, DIWikiPage::newFromTitle( $title ) );

diff --git a/tests/phpunit/Unit/PropertyAnnotators/LinksToPropertyAnnotatorTest.php b/tests/phpunit/Unit/PropertyAnnotators/LinksToPropertyAnnotatorTest.php
@@ -2,7 +2,6 @@
 
 namespace SESP\Tests\PropertyAnnotators;
 
-use PHPUnit_Framework_TestCase;
 use SESP\AppFactory;
 use SESP\PropertyAnnotators\LinksToPropertyAnnotator;
 use SMW\DIProperty;
@@ -14,10 +13,10 @@
  * @covers \SESP\PropertyAnnotators\LinksToPropertyAnnotator
  * @group semantic-extra-special-properties
  *
- * @license GNU GPL v2+
+ * @license GPL-2.0-or-later
  * @since 2.0
  */
-class LinksToPropertyAnnotatorTest extends PHPUnit_Framework_TestCase {
+class LinksToPropertyAnnotatorTest extends \PHPUnit\Framework\TestCase {
 
 	private $property;
 	private $appFactory;
@@ -33,15 +32,13 @@ protected function setUp(): void {
 	}
 
 	public function testCanConstruct() {
-
 		$this->assertInstanceOf(
 			LinksToPropertyAnnotator::class,
 			new LinksToPropertyAnnotator( $this->appFactory )
 		);
 	}
 
 	public function testIsAnnotatorFor() {
-
 		$instance = new LinksToPropertyAnnotator(
 			$this->appFactory
 		);
@@ -56,7 +53,7 @@ public function testAddAnnotation() {
 			->disableOriginalConstructor()
 			->getMock();
 
-		$factory->expects( $this->once() )->method('getConnection');
+		$factory->expects( $this->once() )->method( 'getConnection' );
 
 		$subject = $this->getMockBuilder( DIWikiPage::class )
 			->disableOriginalConstructor()
@@ -90,7 +87,7 @@ public function testNotAddAnnotation() {
 			->getMock();
 
 		$factory->expects( $this->never() )
-			->method('getConnection');
+			->method( 'getConnection' );
 
 		$subject = $this->getMockBuilder( DIWikiPage::class )
 			->disableOriginalConstructor()