Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datatables redesign client side cache mechanism #904

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

thomas-topway-it
Copy link
Contributor

@thomas-topway-it thomas-topway-it commented Feb 2, 2025

  • removes parameter defer-each (set default limit to 100 and retrieve all rows until the limit both on page load and via Ajax)
  • redesign client-side cache mechanism to correctly handle non-subsequent pages and to take advantage from the retrieved rows against table page length

(test further before merging)

Copy link

codecov bot commented Feb 2, 2025

Codecov Report

Attention: Patch coverage is 27.27273% with 8 lines in your changes missing coverage. Please review.

Project coverage is 45.52%. Comparing base (b40de8d) to head (425581d).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
formats/datatables/Api.php 0.00% 7 Missing ⚠️
formats/datatables/Hooks.php 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master     #904   +/-   ##
=========================================
  Coverage     45.51%   45.52%           
+ Complexity     2320     2319    -1     
=========================================
  Files            80       80           
  Lines          9043     9042    -1     
=========================================
  Hits           4116     4116           
+ Misses         4927     4926    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant