Skip to content

Commit

Permalink
AK: Add Utf8View::for_each_split_view() method
Browse files Browse the repository at this point in the history
Returns one Utf8View at a time, using a callback function to identify
code points to split on.

(cherry picked from commit 3f10a5701d9634e47111203b837283bdfc2d8b18)
  • Loading branch information
AtkinsSJ authored and nico committed Nov 16, 2024
1 parent a09d1ca commit bcbcb19
Show file tree
Hide file tree
Showing 2 changed files with 70 additions and 0 deletions.
47 changes: 47 additions & 0 deletions AK/Utf8View.h
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
#pragma once

#include <AK/Format.h>
#include <AK/Function.h>
#include <AK/StringView.h>
#include <AK/Types.h>

Expand Down Expand Up @@ -162,6 +163,52 @@ class Utf8View {
return true;
}

template<typename Callback>
auto for_each_split_view(Function<bool(u32)> splitter, SplitBehavior split_behavior, Callback callback) const
{
bool keep_empty = has_flag(split_behavior, SplitBehavior::KeepEmpty);
bool keep_trailing_separator = has_flag(split_behavior, SplitBehavior::KeepTrailingSeparator);

auto start_offset = 0u;
auto offset = 0u;

auto run_callback = [&]() {
auto length = offset - start_offset;

if (length == 0 && !keep_empty)
return;

auto substring = unicode_substring_view(start_offset, length);

// Reject splitter-only entries if we're not keeping empty results
if (keep_trailing_separator && !keep_empty && length == 1 && splitter(*substring.begin()))
return;

callback(substring);
};

auto iterator = begin();
while (iterator != end()) {
if (splitter(*iterator)) {
if (keep_trailing_separator)
++offset;

run_callback();

if (!keep_trailing_separator)
++offset;

start_offset = offset;
++iterator;
continue;
}

++offset;
++iterator;
}
run_callback();
}

private:
friend class Utf8CodePointIterator;

Expand Down
23 changes: 23 additions & 0 deletions Tests/AK/TestUtf8.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -300,3 +300,26 @@ TEST_CASE(trim)
EXPECT_EQ(view.trim(whitespace, TrimMode::Right).as_string(), "\u180E");
}
}

static bool is_period(u32 code_point) { return code_point == '.'; }

TEST_CASE(for_each_split_view)
{
Utf8View view { "...Well..hello.friends!..."sv };
auto gather = [&](auto split_behavior) {
Vector<StringView> results;
view.for_each_split_view(is_period, split_behavior, [&](auto part) {
results.append(part.as_string());
});
return results;
};

EXPECT_EQ(gather(SplitBehavior::Nothing),
Vector({ "Well"sv, "hello"sv, "friends!"sv }));
EXPECT_EQ(gather(SplitBehavior::KeepEmpty),
Vector({ ""sv, ""sv, ""sv, "Well"sv, ""sv, "hello"sv, "friends!"sv, ""sv, ""sv, ""sv }));
EXPECT_EQ(gather(SplitBehavior::KeepTrailingSeparator),
Vector({ "Well."sv, "hello."sv, "friends!."sv }));
EXPECT_EQ(gather(SplitBehavior::KeepEmpty | SplitBehavior::KeepTrailingSeparator),
Vector({ "."sv, "."sv, "."sv, "Well."sv, "."sv, "hello."sv, "friends!."sv, "."sv, "."sv, ""sv }));
}

0 comments on commit bcbcb19

Please sign in to comment.