Cherry-pick 2 ladybird PRs #25406
Open
Cherry-pick 2 ladybird PRs #25406
+131
−68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This simply adds a ServiceWorkerContainer object to the WorkerNavigator. (cherry picked from commit 2667726b74ae374be2907552795cf56639c4d57f)
(cherry picked from commit 4df280689b5c7f4df53cdcb1c61cb3fed99461c6)
This API is a relic from the time when it was important for objects to have easy access to the Window, and to know it was the global object. We now have more spec-related concepts like relevant_global_object and current_global_object to pull the Window out of thin air. (cherry picked from commit 02a56f648000517f191eeaea2abc68783c097486)
(cherry picked from commit ade4fc177920546c765c5802a57f6d0e9d7434f8)
(cherry picked from commit 0ece40c466dbd6c43fc9b0707d32b3d5d42fe751)
Looking at the spec it doesn't seem like there's a chance for a service worker client to be an environment but not an environment settings object. In the case that that changes in the implementation, we can move it. (cherry picked from commit 237bcbff360d5000ab45da2ca63f196064ab5210)
When a style sheet is removed, all font loaders created from that style sheet should also be removed. (cherry picked from commit 74588a0a16fd3a2cb10c50a58f47b9f5695bc2ff)
github-actions
bot
added
the
👀 pr-needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LadybirdBrowser/ladybird#1293
LadybirdBrowser/ladybird#1486