-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make XRay robust to traces without goal #30
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gasse
force-pushed
the
gasse/patch_4
branch
from
September 18, 2024 15:12
253d2bf
to
5f4c77c
Compare
recursix
previously approved these changes
Sep 18, 2024
src/agentlab/analyze/agent_xray.py
Outdated
goal = step_info.obs["goal"] | ||
try: | ||
goal = step_info.obs["goal"] | ||
except: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
avoid generic except, this can lead to silent error. I think it's except KeyError
or something like that.
recursix
approved these changes
Sep 24, 2024
@@ -648,7 +648,10 @@ def get_episode_info(info: Info): | |||
env_args = info.exp_result.exp_args.env_args | |||
steps_info = info.exp_result.steps_info | |||
step_info = steps_info[info.step] | |||
goal = step_info.obs["goal"] | |||
try: | |||
goal = step_info.obs["goal"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
goal = step_info.obs["goal"] | |
goal = step_info.obs.get("goal", None) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This happens when
env.reset()
fails