Bye langchain 😢 #35
Merged
Bye langchain 😢 #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
recursix
reviewed
Sep 26, 2024
recursix
reviewed
Sep 26, 2024
recursix
reviewed
Sep 26, 2024
recursix
reviewed
Sep 26, 2024
| ) | ||
|
|
||
|
|
||
| # def _convert_messages_to_dict(messages, column_remap={}): |
recursix
reviewed
Sep 26, 2024
recursix
reviewed
Sep 26, 2024
Co-authored-by: Alexandre Lacoste <[email protected]>
ThibaultLSDC
commented
Sep 27, 2024
| self.chat_llm, | ||
| chat_messages, | ||
| n_retry=self.max_retry, | ||
| parser=main_prompt._parse_answer, | ||
| ) | ||
| # inferring the number of retries, TODO: make this less hacky | ||
| stats["n_retry"] = (len(chat_messages) - 3) / 2 | ||
| stats["busted_retry"] = 0 | ||
| except RetryError as e: |
There was a problem hiding this comment.
@recursix i'm not sure how to deal with errors now that ParsingErrors and RetryErrors are raised differently.
There was a problem hiding this comment.
I don't think you need to do anything.
recursix
approved these changes
Oct 2, 2024
| self.chat_llm, | ||
| chat_messages, | ||
| n_retry=self.max_retry, | ||
| parser=main_prompt._parse_answer, | ||
| ) | ||
| # inferring the number of retries, TODO: make this less hacky | ||
| stats["n_retry"] = (len(chat_messages) - 3) / 2 | ||
| stats["busted_retry"] = 0 | ||
| except RetryError as e: |
There was a problem hiding this comment.
I don't think you need to do anything.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing most langchain bits from the codebase