-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bye langchain 😢 #35
Bye langchain 😢 #35
Conversation
) | ||
|
||
|
||
# def _convert_messages_to_dict(messages, column_remap={}): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete old code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor comments to address
Co-authored-by: Alexandre Lacoste <[email protected]>
self.chat_llm, | ||
chat_messages, | ||
n_retry=self.max_retry, | ||
parser=main_prompt._parse_answer, | ||
) | ||
# inferring the number of retries, TODO: make this less hacky | ||
stats["n_retry"] = (len(chat_messages) - 3) / 2 | ||
stats["busted_retry"] = 0 | ||
except RetryError as e: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@recursix i'm not sure how to deal with errors now that ParsingErrors and RetryErrors are raised differently.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you need to do anything.
self.chat_llm, | ||
chat_messages, | ||
n_retry=self.max_retry, | ||
parser=main_prompt._parse_answer, | ||
) | ||
# inferring the number of retries, TODO: make this less hacky | ||
stats["n_retry"] = (len(chat_messages) - 3) / 2 | ||
stats["busted_retry"] = 0 | ||
except RetryError as e: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you need to do anything.
Removing most langchain bits from the codebase