Revert "Omit null query parameters in generated http client (Breaks c…

…ompatibility with ASP.NET WebApi because query arguments are part of the routing selection)" This reverts commit caa74b8.
Serviceware · Jun 5, 2024 · 2199c99 · 2199c99
1 parent 08a5f1a
commit 2199c99
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/src/Dibix.Http.Client/Client/UriBuilder.cs b/src/Dibix.Http.Client/Client/UriBuilder.cs
@@ -23,7 +23,7 @@ private UriBuilder(string url, UriKind kind)
 
         public UriBuilder AddQueryParam<T>(string name, T value) where T : struct => this.AddQueryParam(name, ToString(value));
         public UriBuilder AddQueryParam<T>(string name, T value, T defaultValue) where T : struct => !Equals(value, defaultValue) ? AddQueryParam(name, ToString(value)) : this;
-        public UriBuilder AddQueryParam<T>(string name, T? value) where T : struct => value != null ? AddQueryParam(name, ToString(value)) : this;
+        public UriBuilder AddQueryParam<T>(string name, T? value) where T : struct => this.AddQueryParam(name, ToString(value));
         public UriBuilder AddQueryParam<T>(string name, T? value, T? defaultValue) where T : struct => !Equals(value, defaultValue) ? AddQueryParam(name, ToString(value)) : this;
         public UriBuilder AddQueryParam(string name, string value, string defaultValue) => !Equals(value, defaultValue) ? AddQueryParam(name, ToString(value)) : this;
         public UriBuilder AddQueryParam(string name, string value)

diff --git a/tests/Dibix.Http.Client.Tests/UriBuilderTest.cs b/tests/Dibix.Http.Client.Tests/UriBuilderTest.cs
@@ -11,8 +11,7 @@ public void CrossCheck()
         {
             Uri uri = UriBuilder.Create("some/kind/{of}/uri", UriKind.Relative)
                                 .AddQueryParam("name", "luke")
-                                .AddQueryParam("id", "")
-                                .AddQueryParam("omitnull", (int?)null)
+                                .AddQueryParam("id", (int?)null)
                                 .AddQueryParam("omitdefaultnullint", (int?)null, null)
                                 .AddQueryParam("omitdefaultnullstring", (string?)null, null)
                                 .AddQueryParam("omitdefaultprimitive", 3, 3)