Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(twitch): react 18 support #1004

Merged
merged 6 commits into from
Feb 17, 2024
Merged

fix(twitch): react 18 support #1004

merged 6 commits into from
Feb 17, 2024

Conversation

lennartkloock
Copy link
Member

Proposed changes

Adds support for react 18 and adds a completely unrelated ci doc I wrote.

Types of changes

What types of changes does your code introduce to 7TV?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

CHANGELOG-nightly.md Outdated Show resolved Hide resolved
@TroyKomodo TroyKomodo changed the base branch from master to feat/bug-fixes February 17, 2024 00:48
@lennartkloock lennartkloock changed the title Twitch react 18 support fix(twitch): react 18 support Feb 17, 2024
Copy link
Member

@TroyKomodo TroyKomodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on dev testing site.

@TroyKomodo TroyKomodo merged commit 6a10095 into feat/bug-fixes Feb 17, 2024
5 checks passed
@TroyKomodo TroyKomodo deleted the lennart/react-18 branch February 17, 2024 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants