Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kick: sort emotes for Tab auto-completion #1013

Merged
merged 3 commits into from
Mar 14, 2024

Conversation

kolasss
Copy link
Contributor

@kolasss kolasss commented Mar 8, 2024

Proposed changes

Sort emotes alphabetically with tab auto-completion on Kick

Types of changes

What types of changes does your code introduce to 7TV?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

I just want to KEKW appear before KEKWalk and another KEKW* emotes, much more convenient I think

@CLAassistant
Copy link

CLAassistant commented Mar 8, 2024

CLA assistant check
All committers have signed the CLA.

@kolasss
Copy link
Contributor Author

kolasss commented Mar 14, 2024

@TroyKomodo please review MeAndTroy

@TroyKomodo TroyKomodo changed the base branch from master to feat/bug-fixes March 14, 2024 16:03
@TroyKomodo TroyKomodo merged commit 989da4a into SevenTV:feat/bug-fixes Mar 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants