Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore composing key events to prevent unintended behavior #1059

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

kon72
Copy link
Contributor

@kon72 kon72 commented Aug 7, 2024

Proposed changes

This change fixes an issue where history navigation (up/down arrow key on chat box) was accidentally triggered during IME composition.

Types of changes

What types of changes does your code introduce to 7TV?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

IME is a tool for writing Japanese (and other languages I'm not aware of) where users can select the word they want to enter from the list of words that match the pronounciation given by the user's keystrokes--this process is called composition.
It's pretty common to press arrow key during composition, and that has caused unintended chat history rewinding:

  1. Opens up IME
    Screenshot 2024-08-07 at 12 13 07

  2. After pressing UP
    Screenshot 2024-08-07 at 12 13 34

@CLAassistant
Copy link

CLAassistant commented Aug 7, 2024

CLA assistant check
All committers have signed the CLA.

@lennartkloock lennartkloock merged commit 88450e2 into SevenTV:dev Sep 30, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants