Added Hide Stories option + Fixed Options for recommended channels and vieweres also watch #1062
+75
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Twitch recently introduced Stories to their page. These now have a dedicated button in the sidebar for them.
Since many users are not interested in these stories at all an option to hide this button from the sidebar should be added.
This new button also broke the already existing settings to hide recommended channels and channels that viewers also watch.
The functionality of these 2 settings should be fixed.
Types of changes
What types of changes does your code introduce to 7TV?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
The option to hide the new Stories from the sidebar was pretty straight forward, because Twitch luckily used unique classnames for them.
The fix of the other 2 options is a bit ugly though.
Since the current implementation uses nth child calls to get to the correct divs (that's also the reason why they broke in the first place) and the number of children changes depending on if the sidebar is collapsed or expanded, even more nth child calls were neccessary. This is just a temporary quick fix though. A cleaner solution for a complete refactoring of the sidebar handling already exists by chips here #767