Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Hide Stories option + Fixed Options for recommended channels and vieweres also watch #1062

Merged

Conversation

ChrisScr3ams
Copy link
Contributor

Proposed changes

Twitch recently introduced Stories to their page. These now have a dedicated button in the sidebar for them.
Since many users are not interested in these stories at all an option to hide this button from the sidebar should be added.
This new button also broke the already existing settings to hide recommended channels and channels that viewers also watch.
The functionality of these 2 settings should be fixed.

Types of changes

What types of changes does your code introduce to 7TV?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

The option to hide the new Stories from the sidebar was pretty straight forward, because Twitch luckily used unique classnames for them.
The fix of the other 2 options is a bit ugly though.
Since the current implementation uses nth child calls to get to the correct divs (that's also the reason why they broke in the first place) and the number of children changes depending on if the sidebar is collapsed or expanded, even more nth child calls were neccessary. This is just a temporary quick fix though. A cleaner solution for a complete refactoring of the sidebar handling already exists by chips here #767

@ChrisScr3ams ChrisScr3ams changed the base branch from master to dev August 14, 2024 22:52
@lennartkloock lennartkloock merged commit d31019d into SevenTV:dev Sep 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants