Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add indicator to show the settings sidebar has more options below #799

Merged
merged 4 commits into from
Jul 27, 2023

Conversation

Melonify
Copy link
Contributor

image

Disappears once the user has scrolled down.

@Melonify Melonify added the skip changelog check This pull request does not need a changelog entry label Jul 27, 2023
@Melonify Melonify force-pushed the melonify/settings-sidebar-indicator branch from 918b2a7 to 95bf9ce Compare July 27, 2023 00:43
@Melonify Melonify requested a review from AnatoleAM July 27, 2023 00:48
Copy link
Contributor

@AnatoleAM AnatoleAM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm thinking that clicking the arrow should scroll you down, no?

@Melonify
Copy link
Contributor Author

@AnatoleAM Yeah I considered that, but I'm not sure if having the arrow block the pointer is a good idea or not. It might be annoying for the user to have to scroll before they can click on a tab if the tab is just barely underneath the icon.

@Melonify
Copy link
Contributor Author

But that does make more sense as its common a UX feature.

@Melonify Melonify requested a review from AnatoleAM July 27, 2023 13:33
Copy link
Contributor

@AnatoleAM AnatoleAM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AnatoleAM AnatoleAM merged commit 90a43a5 into master Jul 27, 2023
5 checks passed
@AnatoleAM AnatoleAM deleted the melonify/settings-sidebar-indicator branch July 27, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changelog check This pull request does not need a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants