Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(twitch): broken chat embeds #986

Merged
merged 7 commits into from
Feb 17, 2024

Conversation

pimothyxd
Copy link
Contributor

If a channel moderator received a "suspicious user" message, the message would not get highlighted. A message containing a clip also seemed to not get embedded. The issue causing this seemed to have been Twitch changing their pubsub client.

See the following examples:

image

which should now look like this:

image

and:

image

should now look like this:

image

Should fix: #973

@CLAassistant
Copy link

CLAassistant commented Jan 24, 2024

CLA assistant check
All committers have signed the CLA.

@scotsdez
Copy link

@pimothyxd Just in case you hadn't seen the above about the CLA.

Thanks for fixing 973 - I've actually had to stop using 7TV in the meantime as it was making moderation quite difficult, so I'm quite keen to see this drop in a future release.

@tlstommy
Copy link

@pimothyxd Just in case you hadn't seen the above about the CLA.

Thanks for fixing 973 - I've actually had to stop using 7TV in the meantime as it was making moderation quite difficult, so I'm quite keen to see this drop in a future release.

Is the current extension going to be supported while the new version is being built? or will we have to wait for the new version for extension PRs like this one to be reviewed?

@TroyKomodo TroyKomodo changed the base branch from master to feat/bug-fixes February 17, 2024 01:12
@TroyKomodo
Copy link
Member

Does this still work?
image

@pimothyxd pimothyxd changed the title fix(twitch): update pubsub client fix(twitch): broken chat embeds Feb 17, 2024
@pimothyxd
Copy link
Contributor Author

Does this still work? image

Should be all good now

@TroyKomodo TroyKomodo merged commit 0df249f into SevenTV:feat/bug-fixes Feb 17, 2024
5 checks passed
@pimothyxd pimothyxd deleted the fix/twitch-pubsub-client branch March 10, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Suspicious user messages are not highlighted on Twitch
5 participants